On 2020/03/25 20:37, Adam Wolk wrote:
> On Wed, Mar 25, 2020 at 03:53:10PM +0100, Antoine Jacoutot wrote:
> > On Tue, Mar 24, 2020 at 11:58:12AM -0600, Solene Rapenne wrote:
> > > CVSROOT: /cvs
> > > Module name: ports
> > > Changes by: [email protected] 2020/03/24 11:58:12
> > >
> > > Modified files:
> > > games/yquake2 : Makefile distinfo
> > > games/yquake2/pkg: PLIST
> > >
> > > Log message:
> > > Update to yquake-7.43
> > >
> > > ok awolk@
> > >
> >
> > Does not build.
> >
>
> Apparently both of us had net/curl present, curl
> is optional and dlopened in multiplayer that is why
> it's not picked up by make port-lib-depends-check.
>
> I added it to LIB_DEPENDS and WANTLIB, I'm bumping
> REVISION as this package was buildable on hosts
> that had net/curl present and could be installed.
>
> OK to commit?
If it doesn't show in port-lib-depends-check then please add a comment
to say that it is dlopen()d, otherwise it will likely get removed again
if someone sweeps the tree for wantlib fixes.
> ? yquake2-7.43p0.diff
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/games/yquake2/Makefile,v
> retrieving revision 1.20
> diff -u -p -r1.20 Makefile
> --- Makefile 24 Mar 2020 17:58:12 -0000 1.20
> +++ Makefile 25 Mar 2020 19:33:20 -0000
> @@ -8,6 +8,7 @@ V= 7.43
> PKGNAME= ${N}-${V}
> DISTNAME= quake2-${V}
> CATEGORIES= games
> +REVISION= 0
>
> HOMEPAGE= https://www.yamagi.org/quake2/
> MAINTAINER= Adam Wolk <[email protected]>
> @@ -17,10 +18,11 @@ EXTRACT_SUFX= .tar.xz
> # GPLv2
> PERMIT_PACKAGE= Yes
>
> -WANTLIB += GL SDL2 c m openal pthread
> +WANTLIB += GL SDL2 c curl m openal pthread
>
> LIB_DEPENDS= audio/openal \
> - devel/sdl2
> + devel/sdl2 \
> + net/curl
>
> MAKE_ENV+= VERBOSE=1
> USE_GMAKE= Yes
