On Wed, Jan 23, 2019 at 12:28:59PM +0100, Francesco Pretto wrote:
> On Wed, 23 Jan 2019 at 12:18, Joerg Sonnenberger <[email protected]> wrote:
> >
> > On Mon, Jan 14, 2019 at 11:08:03PM +0100, Francesco Pretto wrote:
> > >
> > > From: Francesco Pretto <[email protected]>
> > >
> > > Fixes warnings in linux since the maximum value of EPdfDataType is 255
> >
> > Please don't do this and look at the history of the code. This chance is
> > intentional for pre-C++11 compat.
> >
> >
> 
> Please, read this thread and the other. The warning I originally intended to 
> fix
> should have just been fixed in [1] by Matthew by switching the underlying 
> value
> from signed to unsigned.

No, you are missing the point. This is intentionally not using the enum
directly as the enum would be larger. Using C++11 sized enums on the
other hand created funny ABI changes.

Joerg


_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to