Hello Francesco, hello all, > On 14 January 2019 at 23:08 Francesco Pretto <[email protected]> wrote: > > > From: Francesco Pretto <[email protected]> > ---src/base/PdfDictionary.cpp | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-)
the lines your patch removes each contain an explicit or implicit lookup, whereas your proposal only has one lookup per method (class members are not called "functions" IIRC) so it removes 5 look-ups (therefore I've changed the subject). More importantly, this patch seems to depend on [PATCH 4/5] in this series for correctness (to avoid a memory leak) because it removes a "delete" operator invocation without replacement (IIRC: doesn't std::map::erase(), like std::vector::erase(), only remove the item(s) from the container but doesn't free their memory, for "reference" types, i.e. not primitives?). Best regards, mabri _______________________________________________ Podofo-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/podofo-users
