On Thu, 2018-11-29 at 16:09 +0100, Michal Sudolsky wrote:
> Proposed patch attached.

        Hi,
thanks for the patch. It causes compiler warnings:

.../podofo/base/../../src/base/PdfEncoding.h: In member function ‘virtual const 
PoDoFo::PdfName& PoDoFo::PdfWin1250Encoding::GetID() const’:
.../podofo/base/../../src/base/PdfEncoding.h:761:16: warning: returning 
reference to temporary [-Wreturn-local-addr]
         return "Win1250Encoding";
                ^~~~~~~~~~~~~~~~~
.../podofo/base/../../src/base/PdfEncoding.h: In member function ‘virtual const 
PoDoFo::PdfName& PoDoFo::PdfIso88592Encoding::GetID() const’:
.../podofo/base/../../src/base/PdfEncoding.h:796:16: warning: returning 
reference to temporary [-Wreturn-local-addr]
         return "Iso88592Encoding";

thus I made some changes to avoid it. Be careful of compiler warnings,
please (though I do not know what compiler you use and with which
options, thus maybe you just didn't see it, because your compiler
didn't generate it).

The updated change is committed as revision 1957:
http://sourceforge.net/p/podofo/code/1957

        Bye,
        zyx



_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to