On Thu, 2018-03-01 at 13:58 +0100, Matthew Brincke wrote:
> How should I review patches which add public API?
Hi,
I guess you mean how to deal with it in this stage, before the release.
The code is not frozen yet, thus new API can be added, especially when
it doesn't influence any existing API internally. I hesitate to change
existing API in this stage, better to left such changes after the
release. If you feel the patch is simple and won't break anything (I
recall I had such feeling about the enum size in 0.9.5, which turned
out into a disaster later, thus it was also my fault), then just commit
as much for the release as possible. It's hard (and time consuming) to
test every single change, but at least the existing tests should not
fail. That's how I do it these days at least.
> I very much hope the sourceforge.net project
> mailing lists and their archive web pages (hopefully with the thread view
> fixed to show all emails, not missing some as it had been) return to proper
> service very soon.
Me too.
Thanks and bye,
zyx
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/podofo-users
