Hi Inge,
thank you for reporting the problem, good spot. The fix (which is
basically what you propose) has already been committed to the CVS.
Cheers,
Paolo
On Mon, Jan 08, 2007 at 03:00:33PM +0100, Inge Bj?rnvall Arnesen wrote:
> /* Need to preprocess data because packet handlers have automagically
> * swapped byte ordering for some primitives */
> void handle_hostbyteorder_packet(struct pkt_data *data)
> {
> data->primitives.vlan_id = htons(data->primitives.vlan_id);
> [snip]
> #if defined HAVE_L2
> struct pkt_primitives *p = &data->primitives;
>
> memcpy(&flow->mac[ndx], &p->eth_shost, 6);
> memcpy(&flow->mac[ndx ^ 1], &p->eth_dhost, 6);
> flow->vlan = p->vlan_id;
> flow->mpls_label[ndx] = extras->mpls_top_label;
> #endif
> [snip]
>
> I believe the former reference is in error as it is not protected by HAVE_L2
> and will thus fail to compile unless layer 2 is enabled. Applying the HAVE_L2
> protection to the former cited code in nfprobe_plugin.c makes pmacct compile
> and link.
>
> all the best,
>
> -- Inge
>
>
> _______________________________________________
> pmacct-discussion mailing list
> http://www.pmacct.net/#mailinglists
_______________________________________________
pmacct-discussion mailing list
http://www.pmacct.net/#mailinglists
