> It might be the hook I gave you a patch for some time ago, I still have > the patch on my download page up to the 2.10 release of MusicInfoSCR, > so I think you introduced it officially in the 2.20 release and removed > it a bit later.
Exactly: # Changelog # 2.30- remove that support again, as addFormat() should do the same... # 2.20- add support for third party plugins (thanks a lot Erland Isaksson!) And you know what? I _never_ checked in neither 2.10 nor 2.20... All I have in my SVN repository is 2.05 and 2.30 :-(. > It looks like the patch took both the $client and $item as > in-parameters which would suggest that the information might be player > specific. I'll give it another try. I'm glad you still have it... Looking at your code I see one thing I think should have to be changed: caching. Who should do the caching? While MIP does some caching anyway, the providing plugin knows much better how long a given value is valid. Let's take your example: when does the collection name change? I guess _never_ within a playlist. If MIP checked for every song this would be a waste of CPU cycles. I'd therefore rather leave it to the information provider or add a parameter which will tell MIP whether to cache or not a value. Eg. 0: don't cache -1: cache for the song's duration > =1: update every x seconds What do you think? -- Michael ----------------------------------------------------------------- http://www.herger.net/SlimCD - your SlimServer on a CD http://www.herger.net/slim - AlbumReview, Biography, MusicInfoSCR _______________________________________________ plugins mailing list [email protected] http://lists.slimdevices.com/lists/listinfo/plugins
