ngraham added inline comments.
INLINE COMMENTS
> potdprovider.cpp:54
> + }
> + }
> }
The lack of error handling and else blocks for all the ifs in this new code
makes me feel a bit nervous.
> config.qml:208
> +
> + function setCategory() {
> + for (var i = 0; i < model.length; i++) {
Since this is only used once, you don't need to make it a function; just put
all of this stuff in the `Component.onCompleted:` directly
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D22494
To: guoyunhe, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
