broulik added inline comments.
INLINE COMMENTS
> Main.qml:414
> + id: logo
> + visible: config.showdistrologo == "shown"
> + source: config.distrologo
Why not just a bool?
> Main.qml:415
> + visible: config.showdistrologo == "shown"
> + source: config.distrologo
> + anchors.horizontalCenter: parent.horizontalCenter
Also set a `sourceSize` and probably `asynchronous: true`
> Main.qml:421
> + fillMode: Image.PreserveAspectFit
> + height: units.largeSpacing * 8
> + Behavior on opacity {
This is not what `spacing` is supposed to be used for. Try `units.gridUnit`
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22458
To: cblack, #vdg, #plasma
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
