broulik added inline comments.
INLINE COMMENTS
> ipv4widget.cpp:451
> + auto dadTimeout = new QSpinBox;
> + dadTimeout->setMinimum(-1);
> + dadTimeout->setValue(m_tmpIpv4Setting.dadTimeout());
a `specialValueText()` for -1 "Default" would have been lovely
> ipv4widget.cpp:460
> +
> + connect(dlg, &QDialog::accepted,
> + [&] () {
Missing a `this` context
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D22344
To: apol, #plasma, jgrulich
Cc: aspotashev, broulik, ngraham, plasma-devel, LeGast00n, jraleigh,
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
