sitter accepted this revision.
sitter added a comment.
some style fixes then ship it plz 👍
INLINE COMMENTS
> drkonqi.cpp:214
> +
> + void removeOldFilesIn(QDir& dir) {
> + auto fileList = dir.entryInfoList(QDir::Files | QDir::NoDotAndDotDot,
& goes to the right of the space; curly brace goes on next line for multi-line
function bodies
> drkonqi.cpp:217
> + QDir::SortFlag::Time |
> QDir::Reversed);
> + if (fileList.size() >= 10) {
> + int filesToRemove = fileList.size() - 9;
This doesn't necessarily need changing, but I want to point out that this and
the following two lines are convoluted, they are simply `for (int i =
fileList.size(); i <= 10; --i) {}` if I am reading this right.
> drkonqi.cpp:219
> + int filesToRemove = fileList.size() - 9;
> + while(filesToRemove--) {
> + auto currentFile = fileList.takeFirst();
space between while and brace
> drkonqi.cpp:232
> + QDir dir(dirname);
> + if(!dir.mkpath(dirname)) {
> + qApp->quit();
space between if and brace
REPOSITORY
R871 DrKonqi
BRANCH
storeGuiless
REVISION DETAIL
https://phabricator.kde.org/D22322
To: tcanabrava, sitter, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas,
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
