davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Nate's crash is due to data not code.
for (int i = 0; i < m_packages.size(); i++) {
QString package = m_packages[i].path();
if (package.at(package.length() - 1) == QChar::fromLatin1('/')) {
<--- you know you crash on this line
we're calling .at(length -1) unconditionally
For an empty string our index will be -1.
This hints towards an insertion bug rather than saying we should just add a
guard here.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22121
To: davidre, #plasma, davidedmundson
Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n,
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
