davidedmundson added inline comments.
INLINE COMMENTS
> sddmauthhelper.cpp:54-55
> +{
> + KUser sddmUser(QStringLiteral("sddm"));
> + KUser sddmGroup(QStringLiteral("sddm"));
> +
do we need two objects representing the same user?
> advanceconfig.cpp:179
> +
> + if (fontconfigPath.isEmpty()) {
> + qDebug() << "fontconfig folder not found";
If it's empty, you print a message, which is fine, but then we still add an
empty entry to our map, and still try to copy the file?
REPOSITORY
R123 SDDM Configuration Panel (KCM)
REVISION DETAIL
https://phabricator.kde.org/D22191
To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, mart
