broulik added inline comments.
INLINE COMMENTS
> menu.cpp:103
> + connect(m_session, &SessionManagement::canLockChanged, this,
> [this]() {
> + m_lockScreenAction->setEnabled(m_session->canLock());
> + });
Indentation
> powermanagementjob.cpp:62
> + setResult(true);
> + return;
> + } else {
Pointless `return`
> powermanagementjob.h:43
> void setKeyboardBrightness(int value, bool silent);
> + SessionManagement *m_session;
> };
Where is it being initialized?
> sessionrunner.cpp:266
>
> - lock();
> dm.startReserve();
This got lost. Ideally that also followed the "automatically lock" setting like
everywhere else, cf. `SessionsModel`
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21764
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
