fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.
> Also do some more sanity checks on the input data.
Are those even necessary at that point? Considering that the referenced
payload properties can still be literally anything and now even direct objects
instead of just stuff converted to JSON and back.
INLINE COMMENTS
> content-script.js:640
> + case "playbackState":
> +
> + if (!["none", "paused", "playing"].includes(payload)) {
Whitespace
> broulik wrote in content-script.js:642
> Oops :)
Yeah, let's keep it "family friendly" ;-)
> content-script.js:661
> + case "callbacks":
> +
> + if (Array.isArray(payload)) {
Whitespace
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D21927
To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, mart
