aacid created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.
REVISION SUMMARY
My libinput touchpad doesn't have an enabled atom so doing
*m_atoms[QLatin1Literal("enabled")].data()
and then using that atom ends up with a crash
So instead of asking the atom out, just pass the atom to compare in
TEST PLAN
Unfortunately i can't really really reproduce the crash, it just happens
every other day, so i can only say "this code is safer and should crash less"
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.16
REVISION DETAIL
https://phabricator.kde.org/D21915
AFFECTED FILES
kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
kcms/touchpad/src/backends/x11/libinputtouchpad.h
kcms/touchpad/src/backends/x11/synapticstouchpad.cpp
kcms/touchpad/src/backends/x11/synapticstouchpad.h
kcms/touchpad/src/backends/x11/xcbatom.h
kcms/touchpad/src/backends/x11/xlibbackend.cpp
kcms/touchpad/src/backends/x11/xlibtouchpad.h
To: aacid
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, mart
