jgrulich added inline comments.
INLINE COMMENTS
> secretagent.cpp:432
> + return true;
> + } else if (requestNew || (allowInteraction &&
> !setting->needSecrets(requestNew).isEmpty()) || (allowInteraction &&
> userRequested) || ((isVpn || isWireGuard) && allowInteraction)) {
> +
Shouldn't it be
(isVpn && !isWireguard) && allowInteraction
You don't want to display password dialog in case it's a WG connection.
Or maybe it should stay and instead we should return true and send error (like
we do when a dialog has an error) if it's a WG connection, to let
NetworkManager know we cannot handle that.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D20930
To: andersonbruce, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
