hein added inline comments.
INLINE COMMENTS
> job.cpp:30
> +
> +#include <QQmlEngine>
> +
Unused?
> notificationgroupcollapsingproxymodel.cpp:194
> +{
> + if (source_parent.isValid() && m_limit > 0) {
> + if (!m_expandedGroups.isEmpty() &&
> m_expandedGroups.contains(source_parent)) {
Check m_limit first for a tiny speedup.
> notifications.cpp:76
> + static uint notificationId(const QModelIndex &idx);
> + QModelIndex mapFromModel(const QModelIndex &idx) const;
> +
Have you considered using `KModelIndexProxyMapper` from KF5::ItemModels?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D20265
To: broulik, #plasma
Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh,
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
