ngraham added a comment.
FWIW the Pager widget uses radio buttons for its vertical/horizontal chooser
UI. We might want to consider doing the same thing here too. I think it's a
nicer UI than having using a checkbox, as it makes the opposite state 100%
explicit.
INLINE COMMENTS
> ConfigAppearance.qml:45
> + id: verticalLookupTable
> + Kirigami.FormData.label: i18n("List:")
> + text: i18n("Vertical")
A list of what? Maybe make it explicit in the label.
> ConfigAppearance.qml:60
> + readOnly: true
> + Kirigami.Theme.inherit: true
> + text: font.family + " " + font.pointSize + "pt"
Is this necessary? I thought `true` was the default for this.
> ConfigAppearance.qml:61
> + Kirigami.Theme.inherit: true
> + text: font.family + " " + font.pointSize + "pt"
> + font: font
This should be translated with `i18nc()` (the correct order of elements may be
different in other languages)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D20906
To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
