filipf added inline comments.
INLINE COMMENTS
> ConfigUnits.qml:89
> +
> + QtControls.ComboBox {
> + id: visibilityComboBox
It was the same before the patch, but how come there's no preselected value for
this option?
> ConfigWeatherStation.qml:69
>
> - RowLayout {
> - Layout.row: 0
> - Layout.column: 1
> + QtControls.Label {
> + id: locationDisplay
F6800225: image.png <https://phabricator.kde.org/F6800225>
selectButton is not horizontally aligned with the combobox below it. To fix it
I think you can do something like `visible: source.length > 0` for this label.
However the button is still not as wide as the combobox, so for that you'd want
to (see next inline comment):
> ConfigWeatherStation.qml:84
> + QtControls.Button {
> + id: selectButton
> + icon.name: "find-location-symbolic"
add `Layout.fillWidth: true` here
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D20896
To: ngraham, #vdg, #plasma, kossebau
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
