fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> mprisplugin.cpp:493
>
> - if (!biggest.isValid() || (actualSize.width() >= biggest.width() &&
> actualSize.height() >= biggest.height())) {
> + if (!biggest.isValid() ||
> + (actualSize.width() >= biggest.width() &&
> actualSize.height() >= biggest.height()
AFAICT this will not work as expected in cases such as 1920x1080 followed by
256x256.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D20736
To: broulik, #plasma, fvogt
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
