broulik added a comment.
+1
INLINE COMMENTS
> ConfigGeneral.qml:44
> Layout.minimumWidth: previewFrame.width + units.smallSpacing * 2
> Layout.maximumWidth: Layout.minimumWidth
> Layout.minimumHeight: previewFrame.height + units.smallSpacing *
> 2
Did you try `Layout.preferredHeight`?
> ConfigGeneral.qml:53
>
> - // just to provide some visual feedback, cannot have checked
> without checkable enabled
> - checkable: true
> - onClicked: {
> - checked = Qt.binding(function() { // never actually allow it
> being checked
> - return iconMenu.status ===
> PlasmaComponents.DialogStatus.Open
> - })
> -
> - iconMenu.open(0, height)
> - }
> + onClicked: iconMenu.opened ? iconMenu.close() : iconMenu.open()
>
I was wondering, while at it, can we make the menu open `onPressed` to be
consistent with all other menus and buttons with menus?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D20612
To: ngraham, #plasma, #vdg
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
