ngraham added a comment.
Thanks, this works great. And kudos for navigating this very old and crusty
code.
INLINE COMMENTS
> componentchooser.cpp:210
> {
> - delete configWidget;
> + foreach (QWidget *configWidget, configWidgetMap)
> + delete configWidget;
No `foreach` in new code. See https://www.kdab.com/goodbye-q_foreach/
Also, follow KDE coding style and always use braces for loops and conditionals.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D20072
To: tigrang, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
