ngraham accepted this revision as: VDG.
ngraham added a comment.
UI looks good now. I've done some code review below:
INLINE COMMENTS
> image.cpp:623
> m_slideshowBackgrounds = paths;
> + Q_FOREACH(const QString &slide, m_uncheckedSlides) {
> + m_slideshowBackgrounds.removeAll(QUrl(slide).path());
Don't use `Q_FOREACH` in new code. See https://www.kdab.com/goodbye-q_foreach/
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19687
To: davidre, #plasma, #vdg, ngraham
Cc: filipf, abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
