ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
This puts permanently disabled checkboxes on the wallpaper delegates that
aren't used in the slideshow version, possibly related to a flood of warnings
that gets printed to the console:
file:///usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/WallpaperDelegate.qml:123:13:
Unable to assign [undefined] to bool
file:///usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/WallpaperDelegate.qml:123:13:
Unable to assign [undefined] to bool
file:///usr/share/plasma/wallpapers/org.kde.slideshow/contents/ui/WallpaperDelegate.qml:123:13:
Unable to assign [undefined] to bool
Let's not show the checkboxes at all unless we're in the slideshow view.
---
Also, this has nothing to do with your patch specifically, but seeing so many
checkesd checkboxes in the slideshow's preview pane makes me realize just how
much I want the Breeze style checkbox to actually look like a checkbox, with a
checkmark instead of just a filled in roundrect.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19687
To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
