sitter added a comment.
I feel like this would be nicer a dbus interface class thingy.
INLINE COMMENTS
> kcmsmserver.cpp:118
> +
> + if (enable) {
> +
> dialog->firmwareSetupMessageWidget->setMessageType(KMessageWidget::Information);
Perhaps reduce the nesting by returning early `if (!enable) { return; }`?
> smserverconfigimpl.cpp:20
>
> +#include <KMessageWidget>
> +
Not needed? .h includes ui_.h and that would include kmessagewidget.h
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D19560
To: broulik, #plasma, #vdg
Cc: sitter, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
