ngraham added inline comments.
INLINE COMMENTS
> configGeneral.qml:21
>
> -import QtQuick 2.0
> -import QtQuick.Controls 1.0 as Controls
> -import QtQuick.Layouts 1.1 as Layouts
> +import QtQuick 2.12
> +import QtQuick.Controls 2.5
Is going that far actually required by anything?
> configGeneral.qml:28
>
> -Layouts.ColumnLayout {
> - id: configGeneral
> +Item {
> + width: childrenRect.width
Why use a top level `Item`? Was there a problem with using the `FormLayout` as
the top-level object?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19670
To: filipf, #plasma, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
