davidedmundson added inline comments.
INLINE COMMENTS
> MainBlock.qml:99
> + id: loginButton
> + implicitHeight: passwordBox.height - units.smallSpacing * 0.5 //
> otherwise it comes out taller than the password field
>
Please add
Accessible.name: "Unlock"
which helps screen readers
> Login.qml:107
> + PlasmaComponents.Button {
> + id: loginButton
> + implicitHeight: passwordBox.height - units.smallSpacing * 0.5 //
> otherwise it comes out taller than the password field
and Accesible.name here
> Login.qml:108
> + id: loginButton
> + implicitHeight: passwordBox.height - units.smallSpacing * 0.5 //
> otherwise it comes out taller than the password field
> + Layout.rightMargin: 1 // prevents it from extending beyond the
> username field
Explain the maths to me for this
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19214
To: rooty, #vdg, #plasma, ngraham, filipf
Cc: davidedmundson, abetts, ngraham, filipf, plasma-devel, jraleigh, GB_2,
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,
mart
