zzag added a comment.
Looks good to me.
I think the test is too much complicated. Would it be simpler to have
something like
QTest::addColumn<QRectF>("geometry");
QTest::addColumn<QPointF>("pos");
QTest::addColumn<bool>("contains");
?
INLINE COMMENTS
> decorationbutton.cpp:455
> + // additional make sure pos is not on the right or bottom edge
> + const bool verInside = d->geometry.width() < 0 ? pos.x() <
> d->geometry.x() :
> + pos.x() <
> d->geometry.right();
No short names.
REPOSITORY
R129 Window Decoration Library
REVISION DETAIL
https://phabricator.kde.org/D15907
To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
