hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
LGTM aside from the minor naming nitpick.
INLINE COMMENTS
> filterproxymodel.cpp:31
> +
> +void FilterProxyModel::setSourceModelProxy(QAbstractItemModel *sourceModel)
> +{
Why did you call this `setSourceModelProxy`? `QSortFilterModel::setSourceModel`
is virtual, you could do the emit in a reimpl?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D18646
To: broulik, #plasma, #vdg, hein
Cc: hein, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen,
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
mart
