anthonyfieroni added inline comments.
INLINE COMMENTS
> NotificationItem.qml:34-47
> + if (bodyText.lineCount > 1) {
> + return mainLayout.height
> + } else {
> + if (appIconItem.valid || imageItem.nativeWidth > 0) {
> + return Math.max((mainLayout.height + 1.5 *
> units.smallSpacing),(units.iconSizes.large + 2 * units.smallSpacing))
> + } else {
> + if (bottomPart.height != 0) {
When you have return you don't need else branch
if (bodyText.lineCount > 1) {
return mainLayout.height
}
if (appIconItem.valid || imageItem.nativeWidth > 0) {
return Math.max((mainLayout.height + 1.5 *
units.smallSpacing),(units.iconSizes.large + 2 * units.smallSpacing))
}
and so on
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D19036
To: rooty, #plasma, #vdg, broulik, ngraham
Cc: anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel, jraleigh,
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,
apol, mart
