bruns added inline comments.
INLINE COMMENTS
> kcm.cpp:197
> + const QString rm = QStandardPaths::findExecutable(QStringLiteral("rm"));
> + const QString balooctl =
> QStandardPaths::findExecutable(QStringLiteral("balooctl"));
> + const QString baloofile =
> QStandardPaths::findExecutable(QStringLiteral("baloo_file"));
IMHO this whole block should be a single, blocking command in balooctl, i.e.
move the whole logic to balooctl.
> kcm.cpp:210
> +
> + // "balooctl start" isn't reliable, so here we run "baloo_file" directly
> + QProcess::startDetached(baloofile, QStringList());
Care to elaborate?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D18890
To: guoyunhe, #plasma, #baloo
Cc: bruns, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,
ashaposhnikov, astippich, spoorun, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, abrahams, sebas, apol, mart
