ngraham added inline comments.
INLINE COMMENTS
> mart wrote in PassiveNotification.qml:65
> this will probably mke the timer always running when the window has focus
> whether or not there is a notificationshown or not?
> something like:
>
> Connections {
> target:root.Window
> onActiveChanged: {
> if(root.opacity == 1) {
> timer.restart();
> }
> }
> }
I don't think so, because this code only runs when `showNotification()` is
called, and the fact that the notification eventually disappears means that the
timer has ended, right?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D18796
To: ngraham, #kirigami, mart, broulik, apol
Cc: plasma-devel, broulik, dkardarakos, apol, davidedmundson, mart, hein
