vpilo updated this revision to Diff 50582.
vpilo added a comment.
- New implementation with a toolbutton
- Also added search reset on Esc keypress, on applet close, on search close
I made a few tests and with all 3 toolbuttons (wifi/mobile/airplane) in
place, also adding the search bar to the toolbar itself makes it cramped and
you can't type a lot in it.
This version IMHO looks neater and I think still pretty unobtrusive, while
still making the feature discoverable by having a button.
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18607?vs=50567&id=50582
BRANCH
vpilo/searchBar (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18607
AFFECTED FILES
applet/contents/ui/PopupDialog.qml
applet/contents/ui/Toolbar.qml
libs/models/appletproxymodel.cpp
To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen,
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
mart