davidedmundson added a comment.
Seems niche, but this solution is also unobtrusive, so I like that. I have a
lot of VPNs searching through them would be quite useful.
Having the search bar on the bottom is a bit weird as when you filter the
results will be at the top, meaning the user's focus is split all over the
place.
INLINE COMMENTS
> PopupDialog.qml:81
> +
> + onContentHeightChanged: isConnectionsListLong = height <
> contentHeight
> + }
The connection view changes height depending on the presence of a search bar
The search bar becomes visible depending on the height of the listview
I would expect that to be giving binding loops when you're on the edge.
> appletproxymodel.cpp:60
> + if (filterRegExp().isEmpty()) {
> return true;
> }
what happens if you have a filter and the the entry is a slave?
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D18607
To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
