jgrulich added inline comments.
INLINE COMMENTS
> fortisslvpnauth.cpp:44
> + const NetworkManager::Setting::SecretFlags otpFlag =
> static_cast<NetworkManager::Setting::SecretFlags>(data.value(NM_FORTISSLVPN_KEY_OTP"-flags").toInt());
> + if (otpFlag == NetworkManager::Setting::None){
> + d->ui.otpFrame->setVisible(false);
I think you should check for NetworkManager::Setting::NotSaved only, if it's
this case, make it visible, if not, make it hidden. It's a one-time password so
it won't be saved.
> fortisslvpnauth.cpp:46
> + d->ui.otpFrame->setVisible(false);
> + }
> + else {
Coding style.
> fortisslvpnwidget.cpp:202
> + data.insert(QLatin1String(NM_FORTISSLVPN_KEY_OTP"-flags"),
> QString::number(NetworkManager::Setting::NotSaved);
> + }
> + else {
Coding style.
> fortisslvpnwidget.cpp:204
> + else {
> + data.insert(QLatin1String(NM_FORTISSLVPN_KEY_OTP"-flags"),
> QString::number(NetworkManager::Setting::None);
> + }
Shouldn't it be NetworkManager::Setting::NotRequired? Using
NetworkManager::Setting::None says the one-time password should be saved to
NetworkManager.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D17834
To: enriquem, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
