davidedmundson added inline comments.
INLINE COMMENTS
> greeterapp.cpp:436
> +
> + view->setFlags(view->flags() | Qt::X11BypassWindowManagerHint);
> +
why are we changing the window flags?
> greeterapp.cpp:451-453
> - if (!w) { // fallback solution
> - w = m_views.first();
> - }
This is still relevant
A cursor can be in none.
> greeterapp.cpp:456
> - // focus setting is still required for proper internal QWidget state
> (and eg. visual reflection)
> - if (!m_testing) {
> - w->setKeyboardGrabEnabled(true); // TODO - check whether this still
> works in master!
we don't want to cursor grab in testing mode, this change is lost
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D17706
To: andreyby
Cc: davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
