fvogt added a comment.
LGTM otherwise.
INLINE COMMENTS
> downloadjob.cpp:152
> + const QString error = it->toString();
> + if (!error.isEmpty()) {
> if (error == QLatin1String("USER_CANCELED")
You could change this into
QString error = payload.value(QStringLiteral("error")).toString();
if(!error.isEmpty())
> downloadjob.cpp:207
> +
> + it = payload.constFind(QStringLiteral("state"));
> + if (it != end) {
Same here as for error above.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D17233
To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
