davidedmundson added inline comments.
INLINE COMMENTS
> rjvbb wrote in backtracegenerator.cpp:140
> You mean move the check on QProcess::Running into the `if
> (line.startsWith(QLatin1String("Process ")) && line.endsWith(QLatin1String("
> detached")))` ?
Yes
Also is it worth adding a "break;" there?
> lldbrc:7
> +[KCrash]
> +Exec=AppleTerminal lldb -p %pid
> +Terminal=true
Is this AppleTerminal line meant to be here?
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D4929
To: rjvbb, #plasma_workspaces, kfunk, davidedmundson
Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik,
kde-mac, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol