davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
seems an ok feature.
INLINE COMMENTS
> SensorDisplay.cpp:401
> + QFileDialog chooser;
> + chooser.setWindowTitle("Save As Image");
> + chooser.setAcceptMode(QFileDialog::AcceptSave);
i18n
> SensorDisplay.cpp:407
> +
> + if ( !chooser.exec() || chooser.selectedFiles().length() == 0 ) {
> + return;
https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0
> SensorDisplay.cpp:418
> + painter.setCompositionMode(QPainter::CompositionMode_SourceAtop);
> + painter.drawImage(point, gl->grabFramebuffer());
> + painter.end();
why not just save the image from gl->grabFramebuffer() instead of painting it
from one image to another.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D16220
To: pflynn, #plasma, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
