davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Use of callLater seems like a neat solution, does it make aboutToPopulate
redundant?
INLINE COMMENTS
> GroupDialog.qml:265
> // only update size once the repeater count matches the model role.
> } else if (!groupRepeater.aboutToPopulate || visualParent.childCount
> == groupRepeater.count) {
> var task;
I remember looking into this.
I was thinking this should be:
(!groupRepeater.aboutToPopulate && visualParent.childCount ==
groupRepeater.count)
As if we're still aboutToPopulate then we shouldn't be doing anything.
But then I changed it and it didn't immediately work so I did nothing.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17006
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
