davidedmundson added a comment.
It's ok as-is, there's a code change that would make things a bit better.
INLINE COMMENTS
> MainBlock.qml:65
> + onAccepted: {
> + if (lockScreenRoot.uiVisible) {
> + startLogin();
It's generally bad practice to reference properties in the parent scope, it
makes future refactors very difficult.
I would prefer an explicit property on MainBlock and then have LockScreenUi.qml
bind that when it instantiates the MainBlock.
REPOSITORY
R120 Plasma Workspace
BRANCH
arc_enterpressed (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D16219
To: thsurrel, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel,
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
