davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Looks mostly good.
At some point we'll need to add this property to the wayland output
protocols, but that can be later.
INLINE COMMENTS
> xrandroutput.cpp:178
> m_primary = primary;
> + m_hotplugModeUpdate = XRandR::hasProperty(m_id, "hotplug_mode_update");
> }
This code path potentially updates this var twice.
Would it be better to do this inside the
} else if (conn == XCB_RANDR_CONNECTION_CONNECTED) {
> xrandroutput.cpp:212
> }
> + m_hotplugModeUpdate = XRandR::hasProperty(m_id, "hotplug_mode_update");
>
why are we querying if the property exists rather than if the property is 1?
REPOSITORY
R110 KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D15789
To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
