davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fetchsqlite.cpp:104
> +
> +QStringList FetchSqlite::tables(QSql::TableType type)
> +{
please guard this with the mutex
> fetchsqlite.cpp:106
> +{
> + auto m_db = QSqlDatabase();
> + bool wasOpen = m_db.isOpen();
you're shadowing m_db
it'll never be open
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D15488
To: bruns, #frameworks, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
