broulik added inline comments.
INLINE COMMENTS
> Action.qml:172
> + */
> + function isSeparator() {
> + return separator;
That function is superfluous, you have the property after all
> ActionsMenu.qml:55
> if (!action.children || action.children.length === 0) {
> - item = theMenu.itemDelegate.createObject(null, {
> ourAction: action });
> + if (typeof action.isSeparator === "function" &&
> action.isSeparator()) {
> + item = theMenu.separatorDelegate.createObject(null,
> {});
`if (action.separator)`?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D15143
To: dkardarakos, mart
Cc: broulik, plasma-devel, apol, davidedmundson, mart, hein
