ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
What branch did you make this patch against? It doesn't apply for me against
master:
error: while searching for:
m_list->setHeaderLabels(columns);
QHBoxLayout *hbox=new QHBoxLayout();
box->addItem(hbox);
m_updateButton=new QPushButton(i18n("&Update"),this);
hbox->addWidget(m_updateButton);
hbox->addStretch(1);
QTimer* timer=new QTimer(this);
timer->start(60000);
connect(m_updateButton, &QPushButton::clicked, this,
&KCMNic::update);
error: patch failed: Modules/nics/nic.cpp:95
Applying patch Modules/nics/nic.cpp with 1 reject...
Rejected hunk #1.
Patch Failed!
Usage Exception: Unable to apply patch!
Also, on the subject of improving the button itself (which I am fully in
support of), that would be for another patch anyway.
INLINE COMMENTS
> nic.cpp:98
> box->addItem(hbox);
> +
> m_updateButton=new QPushButton(i18n("&Update"),this);
Unrelated whitespace change; please revert.
> nic.cpp:102
> + hbox->addWidget(m_updateButton);
> +
> QTimer* timer=new QTimer(this);
Unrelated whitespace change; please revert.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D14737
To: schampailler, ngraham
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, sebas, apol, mart
