romangg added inline comments.
INLINE COMMENTS
> outputdevice.cpp:161
> + int32_t subPixel, const char *make, const char
> *model,
> + int32_t transform)
> {
Unrelated change.
> outputdevice_interface.cpp:153
> + connect(this, &OutputDeviceInterface::serialNumberChanged, this,
> [this, d] { d->updateGeometry(); });
> + connect(this, &OutputDeviceInterface::eisaIdChanged, this,
> [this, d] { d->updateGeometry(); });
> connect(this, &OutputDeviceInterface::scaleChanged, this,
> [this, d] { d->updateScale(); });
needs fix
> outputdevice_interface.cpp:410
> + wl_resource_post_event(resource,
> + ORG_KDE_KWIN_OUTPUTDEVICE_GEOMETRY,
> globalPosition.x(),
Why change? Unrelated.
> outputdevice_interface.h:50
> +//KF6 TODO - This class sends absolute garbage over the wire constantly.
> +//sendDone needs to be explicit, anything related to the geometry event
> needs to be in a single method
> +
What do you mean with "needs to be explicit"?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D10040
To: davidedmundson, graesslin, sebas, #kwin, dvratil
Cc: romangg, kde-frameworks-devel, davidedmundson, plasma-devel, ragreen,
Pitel, schernikov, michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
