broulik added a comment.
+1 for the looks
INLINE COMMENTS
> Full.qml:27
> +Item {
> + anchors.fill: parent
> +
We typically do that where the component is used, not in its definition
> Full.qml:30
> PlasmaExtras.Heading {
> - Layout.fillWidth: true
> + anchors.left: parent.left
> + anchors.top: parent.top
`width: parent.width` instead of those nachors
Otherwise the label won't wrap if it's too long (localization)
> Full.qml:37
>
> Label {
> + id: numberOfUpdatesLabel
I would prefer if you still used a `ColumnLayout` for those two elements
instead of a gazillion anchors
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D14238
To: ngraham, apol, #discover_software_store, #vdg
Cc: broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, sebas, apol, mart
