zzag added inline comments.
INLINE COMMENTS
> osd.cpp:58
>
> - const QString &osdPath =
> QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation,
> QStringLiteral("kded_kscreen/qml/Osd.qml"));
> + QString osdPath =
> QStandardPaths::locate(QStandardPaths::QStandardPaths::GenericDataLocation,
> QStringLiteral("kded_kscreen/qml/Osd.qml"));
> if (osdPath.isEmpty()) {
Please keep `const`.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D14152
To: gladhorn, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
