zzag added inline comments.
INLINE COMMENTS
> widget.h:46-48
> +namespace Ui {
> + class KScreenWidget;
> +}
Coding style nitpick:
namespace Ui
{
class KScreenWidget;
}
> widget.h:96
> private:
> + Ui::KScreenWidget *ui;
> QMLScreen *mScreen = nullptr;
Naming nitpick: mUi
REPOSITORY
R104 KScreen
BRANCH
gladhorn/ui
REVISION DETAIL
https://phabricator.kde.org/D14024
To: gladhorn, #plasma, sebas, davidedmundson
Cc: zzag, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart